Add tests on fixed ICEs #47044
Merged
Add tests on fixed ICEs #47044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| } | ||
|
|
||
| impl Trait { | ||
| //~^ ERROR E0038 |
There was a problem hiding this comment.
Could you use actual error messages instead of codes outside of E0___.rs tests?
There was a problem hiding this comment.
Thank you for your review. Updated and rebased.
There was a problem hiding this comment.
@topecongiro could you do that change in all compile-fail files?
topecongiro
force-pushed
the
fixed-ices
branch
from
17305b1 to
12a9ab0
Compare
kennytm
added
the
S-waiting-on-review
estebank
approved these changes
Dec 28, 2017
|
#39953 is a PR, removed from description. |
Closes rust-lang#29924. Closes rust-lang#38857. Closes rust-lang#39665. Closes rust-lang#39872. Closes rust-lang#39553. Closes rust-lang#41210. Closes rust-lang#41880. Closes rust-lang#43483.
topecongiro
force-pushed
the
fixed-ices
branch
from
12a9ab0 to
b3c022d
Compare
|
@bors r+ rollup |
|
📌 Commit b3c022d has been approved by |
bors
added a commit
that referenced
this pull request
Dec 31, 2017
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29924. Closes #38857. Closes #39665. Closes #39872.
Closes #41210. Closes #41880. Closes #43483.
Note that compile-fail/E0599.rs is for #41210.